Skip to content

Conversation

@harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Dec 10, 2024

This PR can be used as reference to run presubmit integration tests against cloud-devel. It was used for testing multiplexed sessions read-write feature.

@harshachinta harshachinta requested review from a team as code owners December 10, 2024 06:13
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 10, 2024
value: "true"
}

env_vars: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also change continuous and nightly jobs as well?

@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 10, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 17, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 17, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 20, 2025
@sakthivelmanii
Copy link
Collaborator

@harshachinta is this still needed?

@harshachinta
Copy link
Contributor Author

Closing this PR as integration tests against cloud-devel are verified

@harshachinta harshachinta changed the title chore(spanner): add environment variable for enabling rw multiplexed sessions chore(spanner): verify mux tests against cloud-devel Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants